Use LUT for linear to sRGB conversion #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I didn't see that there were more tests. |
|
This test fails even on main on my machine: |
That might not be an issue; that test has failed randomly anyway. Can you maybe check the visuals for decoding? |
|
Cross-checked with #14, doesn't fail. |
|
Would this be a case for https://docs.rs/phf/latest/phf/ ? 🤔 |
|
@thvdveld a rebase on main should make the tests pass with a higher probability ;-) |
Using a LUT for the linear to sRGB conversion improves decoding
performance for the decode_into benchmark:
```
decode_into LGF5]+Yk^6#M@-5c,1J5@[or[Q6./200
time: [766.58 µs 769.86 µs 776.05 µs]
change: [-62.967% -62.784% -62.602%] (p = 0.00 < 0.05)
Performance has improved.
```
However, the size of the LUT is 8.192 u8. The `fast-linear-to-srgb`
feature flag was added, which is enabled by default. In cases where
binary size is more important than performance, the feature can be
disabled.
Another note in the implementation: using a lookup table reduces the
accuracy of the conversion, compared to the original implementation.
But all current tests pass. Higher accuracy can be achieved by
increasing the LUT size.
|
All checks have passed! 🎉 |
|
On my armv7 phone: That's 10ms faster :'-) |
gferon
reviewed
Jul 23, 2024
gferon
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a LUT for the linear to sRGB conversion improves decoding performance for the decode_into benchmark:
However, the size of the LUT is 8.192 u8. The
fast-linear-to-srgbfeature flag was added, which is enabled by default. In cases where binary size is more important than performance, the feature can be disabled.Another note in the implementation: using a lookup table reduces the accuracy of the conversion, compared to the original implementation. But all current tests pass. Higher accuracy can be achieved by increasing the LUT size.